Publish unit test results for pull request builds #2837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Numpsy
commented
Sep 29, 2024
| @@ -393,8 +393,10 @@ let callPaket wd args = | |||
| /// <param name="dllPath">Test assembly to run tests from</param> | |||
| /// <param name="resultsXml">Expecto test results XML file</param> | |||
| let runExpecto workDir dllPath resultsXml = | |||
| let resultsFile = "testresults" </> resultsXml | |||
There was a problem hiding this comment.
As it stands, the test result xml files get written into the root directory of the repository, but it's easier to upload them in a batch if they all get written into a subdirectory and this looked like the easiest place to change to do that
xperiandri
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on comments in #2818 - publish the unit test results files during CI builds, and then publish a test report using https://github.com/EnricoMi/publish-unit-test-result-action.
This first attempt is based on the action documentation, and on some implementations in other repositories (This is the first time I've used it myself)
Note: It appears that Github won't pick up the new publish-test-results action until the yaml file for it is in the master branch, so I've had to merge a test change into the master branch in my fork to test it - you can see the results for that at https://github.com/Numpsy/FAKE/runs/30818769728 which looks reasonable.
Not sure if it'll need tuning to control where the test results get pushed to - e.g. if they get displayed inline inside pull requests as well as in the build results page.